Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on julia 1.6.x #126

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Standardize on julia 1.6.x #126

merged 3 commits into from
Jan 18, 2022

Conversation

tsj5
Copy link
Collaborator

@tsj5 tsj5 commented Jan 7, 2022

Resolves #125.

This PR updates environment specs for the project and its examples to use julia 1.6.x, the current long-term support release:

  • Adds julia 1.6.x as a versioned dependency in all Project.toml files,
  • Updates all Manifest.toml files to package versions appropriate for julia 1.6.5,
  • Changes the buildkite env to use julia 1.6.5 instead of 1.5.4.

@tsj5 tsj5 changed the title Standardize on julia 1.6.x [WIP] Standardize on julia 1.6.x Jan 7, 2022
@tsj5 tsj5 requested a review from odunbar January 7, 2022 21:00
@tsj5 tsj5 self-assigned this Jan 7, 2022
@odunbar
Copy link
Collaborator

odunbar commented Jan 18, 2022

OK let's try this patch to get the buildkite moving along

Copy link
Collaborator

@odunbar odunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will likely change on releasing the package, but is fine for compatability now

@odunbar
Copy link
Collaborator

odunbar commented Jan 18, 2022

bors r+

@bors bors bot merged commit f584747 into CliMA:staging Jan 18, 2022
@bors
Copy link
Contributor

bors bot commented Jan 18, 2022

Build failed:

@tsj5 tsj5 mentioned this pull request Jan 18, 2022
7 tasks
@tsj5
Copy link
Collaborator Author

tsj5 commented Jan 18, 2022

Thanks for the approval, @jakebolewski and @odunbar -- apologies things are still broken! One of you will need to check which environment modules are available in order to fix things:

The new CI error the current PR encounters is that the julia executable can't be found (line 103), due to the fact (line 5) that it's

ModuleCmd_Load.c(213):ERROR:105: Unable to locate a modulefile for 'julia/1.6.5'

My understanding is that buildkite jobs are running on your own cluster (not containerized), so I'd need one of you to look up the available environment modules on that machine in order to fix this. 1.6.5 was only released a month ago, so it may be premature to expect it to be available.

I'm confused by the fact that Oceananigans.jl specifies 1.6.5 in its buildkite setup, yet the CI on main is passing. I'm guessing it runs on a different machine, due to GPU use?

@tsj5 tsj5 mentioned this pull request Jan 18, 2022
bors bot added a commit that referenced this pull request Jan 20, 2022
127: [WIP] Standardize on Julia 1.6.2 r=jakebolewski a=tsj5

This is a revision of PR #126, which ran into a new problem (missing environment module) when attempting to fix #125 (Manifest.toml incompatibility between julia 1.5 and 1.6). See [most recent comment](#126 (comment)) on that PR.

Current PR pins the buildkite julia version at 1.6.2, for which a module currently exists. 

The `Manifest`s in this PR were generated under 1.6.5, and I haven't been able to verify that they're compatible with 1.6.2 (julialang.org didn't retain 1.6.2, and the conda package for 1.6.2 appears to be broken on osx).

Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Thomas Jackson <[email protected]>
@tsj5 tsj5 changed the title [WIP] Standardize on julia 1.6.x Standardize on julia 1.6.x Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants